-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all Python-related code #290
Conversation
These will be added back later
If desired, this functionality could be later be provided by Preferences.jl
I've opted to move the PyPlot code to a new repo https://github.com/arviz-devs/ArviZPyPlot.jl, since it will likely be much less developed in the future than the Julia plotting packages and thus does not need to be very tightly coupled to changes in this package. That package depends on v0.9 of this package, so I will merge this PR, open a PR removing the Quickstart docs, register v0.9, and then after ArviZPyPlot is registered revert the PR to reintroduce the Quickstart docs. |
This is a massive update that removes all Python-related code from the package.
It also:
kde
andsummarystats
. These will be added back in later, which will be a non-breaking changeCloses #92 #172 #187
Fixes #130 #137 #188 #206
Relates #129
With this PR, we are more-or-less ready for a new breaking release, except we should release the plotting package first, which should either be in its own repo or in this one (in this case some of these commits will be reverted so we can move the code to a subdir and keep the git history)
Load time comparison
Before this PR:
After this PR:
This reduces to 0.77s on v1.10.0-alpha1, and #288 should also significantly reduce load time.
Edit: and 0.58s on v1.10.0-beta1!