Skip to content

fix(ui): resolve scroll button overlap and clean footer layout #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SHIKHARCHATURVEDI19 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): resolve scroll button overlap and clean footer layout #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions frontend/src/components/ScrollToTop.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,16 @@ import { ArrowUp } from "lucide-react";
const ScrollToTop = () => {
const [isVisible, setIsVisible] = useState(false);
const location = useLocation();
// Hide the button on login and root pages
const isLoginPage =
location.pathname === "/login" || location.pathname === "/";

// Hide the button on login and root pages
const isLoginPage = location.pathname === "/login" || location.pathname === "/";

// Toggle visibility based on scroll position
// Toggle visibility based on scroll position
//little changed
const toggleVisibility = () => {
if (window.scrollY > 100) {
setIsVisible(true);
} else {
setIsVisible(false);
}
setIsVisible(window.scrollY > 100);
};

// Scroll to top function
// Scroll to top function
const scrollToTop = () => {
window.scrollTo({
top: 0,
Expand Down Expand Up @@ -48,7 +44,8 @@ const ScrollToTop = () => {
if (isLoginPage) return null;

return (
<div className="fixed bottom-6 right-6 z-50">
/* FIXED */
<div className="fixed right-6 bottom-24 sm:bottom-24 md:bottom-24 lg:bottom-24 z-50">
{shouldShow && (
<button
onClick={scrollToTop}
Expand All @@ -62,4 +59,4 @@ const ScrollToTop = () => {
);
};

export default ScrollToTop;
export default ScrollToTop;