fix(security): resolve IDOR vulnerability in public routines endpoint#1594
Open
Abhishek2005-ard wants to merge 38 commits into
Open
fix(security): resolve IDOR vulnerability in public routines endpoint#1594Abhishek2005-ard wants to merge 38 commits into
Abhishek2005-ard wants to merge 38 commits into
Conversation
…y required checks
…/Abhishek2005-ard/DailyForge into fix/animated-routes-not-rendered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves an Insecure Direct Object Reference (IDOR) vulnerability in the
getPublicRoutineendpoint. Previously, any routine could be fetched by its ID without authentication, unintentionally exposing private user routines if an ID was guessed or leaked.Changes Made
isPublicboolean flag (default:false) to theRoutinemodel.getPublicRoutineto return a403 Forbiddenresponse for routines that exist but are not explicitly marked as public.updateRoutineto accept and process the newisPublicfield.RoutineCard.jsxnow automatically triggers an API call to setisPublic: truebefore generating the link.Testing Performed
/routines/public/:idfor private routines return403.close #1566