fix(security): prevent DoS by bounding pagination limit in getTasks#1595
Open
Abhishek2005-ard wants to merge 39 commits into
Open
fix(security): prevent DoS by bounding pagination limit in getTasks#1595Abhishek2005-ard wants to merge 39 commits into
Abhishek2005-ard wants to merge 39 commits into
Conversation
…y required checks
…/Abhishek2005-ard/DailyForge into fix/animated-routes-not-rendered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves an Application Denial of Service (DoS) vulnerability in the
getTasksendpoint. Previously, thelimitquery parameter was unbounded, allowing an attacker to request an excessively large number of tasks (e.g.,?limit=1000000). This could exhaust server memory and database resources.Changes Made
MAX_TASK_LIMITconstant set to100.Math.min(..., MAX_TASK_LIMIT)to strictly enforce the upper boundary while still maintaining the existingMIN_TASK_LIMIT.Testing Performed
?limit=500accurately caps the returned records to 100 and no longer attempts an unbounded query.?limit=10) continue to operate as expected.close #1567