fix : added inline error in Analytics export failure - #2063
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix : added inline error in Analytics export failure#2063tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Replaced the
alert()dialog inAnalytics.jsxexportToImagefunction with an inline error state. AnimageExportErrorstate was added to display the error message directly in the header area.Changes Made
imageExportErrorstate variable to the componentalert()call inexportToImagecatch block withsetImageExportError()Impact it Made
Closes #2058
Note
Please assign this PR to the
tmdeveloper007account.