Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example brdf data and brdf schema #140

Conversation

ClemensLinnhoff
Copy link
Collaborator

@ClemensLinnhoff ClemensLinnhoff commented Oct 14, 2024

Describe your changes

  • Add example brdf data for radar, lidar and camera,
  • Add brdf schema
  • Add automatic documentation generation for brdf schema

Please check out, how the documentation will look on my fork:
https://clemenslinnhoff.github.io/OpenMATERIAL/asamopenmaterial/latest/specification/material/material-brdf-schema.html

Issue ticket number and link

Fixes #50, fixes #126

Checklist before requesting a review

  • I have performed a self-review of my code/documentation.
  • My changes generate no new warnings during the documentation generation.

@ClemensLinnhoff
Copy link
Collaborator Author

Waiting for PR #138 to be merged. Then the automatic documentation generation can be added to the new structure introduced in that PR.

@KimuraDIVP KimuraDIVP marked this pull request as ready for review October 22, 2024 00:30
@ClemensLinnhoff ClemensLinnhoff marked this pull request as draft October 23, 2024 12:47
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review October 23, 2024 15:51
Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General review.
Signed-off-by: Diego Sánchez [email protected]

@ClemensLinnhoff ClemensLinnhoff merged commit 789aa20 into asam-ev:main Oct 25, 2024
2 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the 50-add-brdf-look-up-table-to-the-material-data branch October 25, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a sample of a BRDF lookup table. Add BRDF look-up table to the material data
3 participants