Add example brdf data and brdf schema #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ClemensLinnhoff <[email protected]>
|
Waiting for PR #138 to be merged. Then the automatic documentation generation can be added to the new structure introduced in that PR. |
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
AsamDiegoSanchez
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
General review.
Signed-off-by: Diego Sánchez [email protected]
KimuraDIVP
approved these changes
Oct 25, 2024
ClemensLinnhoff
deleted the
50-add-brdf-look-up-table-to-the-material-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Please check out, how the documentation will look on my fork:
https://clemenslinnhoff.github.io/OpenMATERIAL/asamopenmaterial/latest/specification/material/material-brdf-schema.html
Issue ticket number and link
Fixes #50, fixes #126
Checklist before requesting a review