Add images for vehicle structure #146
Conversation
Signed-off-by: FabianKlopfer <[email protected]>
|
Here are my remarks from #103: Please make sure, that the coordinate frame fit to the description of the specific element. For example the coordinate frome on the front door (engine hood) does not comply to the description. Please also make sure that all illustrations are consistent.
Could you change the color/grayscale of the coordinates so that they are visible both in light and dark mode? |
Signed-off-by: FabianKlopfer <[email protected]>
There was a problem hiding this comment.
@ClemensLinnhoff: I updated the image and fixed the coordinate system. If x points forward and the z-axis is perpendicular to the x-axis (or rather to the x-y-plane to make it less ambiguous), then the y-axis in the right-handed coordinate system would point to the left.
Can you please doublecheck and confirm whether I interpreted the definition correctly? We will then update the other interior images.
There was a problem hiding this comment.
Yes, that looks correct.
There was a problem hiding this comment.
I added this image of a hinged bus to explain the orientation of vehicle parts. However, it was not easy to visualize that the y-axis points to the left in driving direction of the part in the back. We might also need to update the image as soon as the working group has decided on the origin of the coordinate system for vehicle parts.
@ClemensLinnhoff: Can you please check whether you agree with the visualization of the coordinate system?
There was a problem hiding this comment.
The bus itself looks very nice (although I think the front part needs to have two axes).
For the coordinate system, as you already mentioned, the y-axis looks a bit weird. Does not seem to be in a right angle to the other axes.
But we need to decide first, where exactly the origins of the vehicle parts should be, see #148.
There was a problem hiding this comment.
Thanks for the fast reply. You are right about the second axle. I missed that it he first shot, but added it now.
We will update the coordinate system as soon as there is a decision on its origin. Maybe we could improve it by changing the arrow direction of the y-axis to lower left as below, where I rotated the y-axis by 45° to the left of the x-axis.
There was a problem hiding this comment.
I reused the bus image to illustrate the blindspot image mounting. However, the 3D perspective makes it hard to visualize the axes of the coordinate system. In this case, the z- and y-axes are easy, but I had issues with the rotation of the x-axis.
@ClemensLinnhoff: Can you please check the rotation of the x-axis and the origin of the coordinate system (I interpreted "base" as lowest point of the mounting, but it could also refer to the centre)? We could also create a new image from the bus driver's perspective, which could be reused in Grp_Mirror_Blindspot_View.
Describe your changes
Adding images to illustrate vehicle structure
Issue ticket number and link
PR 103