Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terms and definitions #25

Merged
merged 15 commits into from
Jul 16, 2024
Merged

Conversation

ClemensLinnhoff
Copy link
Collaborator

@ClemensLinnhoff ClemensLinnhoff commented Jun 26, 2024

Describe your changes

Adding terms and definitions as a result of multiple project meetings.

Issue ticket number and link

Fixes #24, related to #18.

Checklist before requesting a review

  • I have performed a self-review of my code/documentation.
  • My changes generate no new warnings during the documentation generation.

Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff ClemensLinnhoff linked an issue Jun 26, 2024 that may be closed by this pull request
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff ClemensLinnhoff changed the title Add content from other branch Add terms and definitions Jun 26, 2024
@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review June 26, 2024 05:55
ClemensLinnhoff and others added 2 commits July 2, 2024 17:45
Signed-off-by: ClemensLinnhoff <[email protected]>
Co-authored-by: Ann-Cathrin Mackenthun <[email protected]>
Co-authored-by: Ann-Cathrin Mackenthun <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff ClemensLinnhoff force-pushed the 24-cleanup-terms-and-definitions branch from 8b8323f to e288ee7 Compare July 2, 2024 15:46
Signed-off-by: ClemensLinnhoff <[email protected]>

Co-authored-by: Ann-Cathrin Mackenthun <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff ClemensLinnhoff force-pushed the 24-cleanup-terms-and-definitions branch from 89df4a4 to e5d7a0a Compare July 3, 2024 12:52
@ClemensLinnhoff
Copy link
Collaborator Author

@ACMackenthun please fix the DCO of your last commit.

Copy link
Collaborator Author

@ClemensLinnhoff ClemensLinnhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ACMackenthun I commented some last remarks.

Copy link
Collaborator

@LudwigFriedmann LudwigFriedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor corrections

content/terms_and_definitions/terms_and_definitions.adoc Outdated Show resolved Hide resolved
content/terms_and_definitions/terms_and_definitions.adoc Outdated Show resolved Hide resolved
content/terms_and_definitions/terms_and_definitions.adoc Outdated Show resolved Hide resolved
content/terms_and_definitions/terms_and_definitions.adoc Outdated Show resolved Hide resolved
content/terms_and_definitions/terms_and_definitions.adoc Outdated Show resolved Hide resolved
content/terms_and_definitions/terms_and_definitions.adoc Outdated Show resolved Hide resolved
Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view it can be merged after adding the last suggested changes.

@mettelilienthal
Copy link
Collaborator

@LudwigFriedmann I have updated the file with your desired changes. If you agree with everything now and approve the PR, we can merge it into main.

@FKlopfer
Copy link
Collaborator

@AsamDiegoSanchez , can you merge the PR?

@AsamDiegoSanchez AsamDiegoSanchez merged commit 51b1c3f into main Jul 16, 2024
1 check passed
@ClemensLinnhoff ClemensLinnhoff deleted the 24-cleanup-terms-and-definitions branch August 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup terms and definitions
6 participants