Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json examples for material and asset files #29

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Add json examples for material and asset files #29

merged 8 commits into from
Aug 2, 2024

Conversation

ClemensLinnhoff
Copy link
Collaborator

@ClemensLinnhoff ClemensLinnhoff commented Jul 3, 2024 •
edited by nakohdo
Loading

Describe your changes

  • Add examples for material and asset
  • Add JSON schema files fitting the examples
  • Add JSON validation pipeline

Issue ticket number and link

#28

Mention a member

@nakohdo You could take this branch and continue with the JSON validation pipeline.

Checklist before requesting a review

  • I have performed a self-review of my code/documentation.
  • My changes generate no new warnings during the documentation generation.

@ClemensLinnhoff ClemensLinnhoff linked an issue Jul 3, 2024 that may be closed by this pull request
Add json examples for material and asset files #28
Closed
@ClemensLinnhoff
Add space at the end for the files
104b63e 
Signed-off-by: ClemensLinnhoff <[email protected]>
ipg-jsc
ipg-jsc reviewed Jul 4, 2024
View reviewed changes
schemas/asset_schema.json Show resolved Hide resolved
schemas/asset_schema.json Outdated Show resolved Hide resolved
schemas/asset_schema.json Show resolved Hide resolved
@ClemensLinnhoff
Copy link
Collaborator Author

@nakohdo What is the state of the JSON validation pipeline?

@nakohdo nakohdo marked this pull request as ready for review August 1, 2024 11:32
ClemensLinnhoff
ClemensLinnhoff commented Aug 1, 2024
View reviewed changes
.github/workflows/validate-json.yaml Outdated Show resolved Hide resolved
.github/workflows/validate-json.yaml Outdated Show resolved Hide resolved
@nakohdo
Copy link
Collaborator

nakohdo commented Aug 1, 2024

Hi @ClemensLinnhoff,
I have implemented your suggestions. We might make the trigger more specific to only fire on changes in the schema folders.

@ClemensLinnhoff
Copy link
Collaborator Author

Hi @ClemensLinnhoff, I have implemented your suggestions. We might make the trigger more specific to only fire on changes in the schema folders.

Good idea. It needs to be triggered on changes in the example folder or the schema folder.

@ClemensLinnhoff ClemensLinnhoff added the isState:ForCCBreview CCB will review it and change the status to ReadyForMerge if everything is ok label Aug 1, 2024
AsamDiegoSanchez
AsamDiegoSanchez approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remarks from my side.
Signed-off-by: Diego Sánchez [email protected]

ipg-jsc
ipg-jsc approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@ipg-jsc ipg-jsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created to follow-up issues (#45 & #51)
But this is perfectly fine for a first example.

@ClemensLinnhoff ClemensLinnhoff added isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager and removed isState:ForCCBreview CCB will review it and change the status to ReadyForMerge if everything is ok labels Aug 2, 2024
@ClemensLinnhoff
Copy link
Collaborator Author

CCB decision 02.08.24: Merge as is

@ClemensLinnhoff ClemensLinnhoff merged commit 4963802 into main Aug 2, 2024
2 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the 28-add-json-examples-for-material-and-asset-files branch August 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipg-jsc ipg-jsc ipg-jsc approved these changes

@AsamDiegoSanchez AsamDiegoSanchez AsamDiegoSanchez approved these changes

@LudwigFriedmann LudwigFriedmann Awaiting requested review from LudwigFriedmann

@drsftx73 drsftx73 Awaiting requested review from drsftx73

Assignees

@ClemensLinnhoff ClemensLinnhoff

Labels
isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add json examples for material and asset files
4 participants
@ClemensLinnhoff @nakohdo @ipg-jsc @AsamDiegoSanchez