-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electromagnetic_properties_uri #70
Conversation
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@KimuraDIVP, @DavidJRitter904, @SandroReith, @drsftx73 what do you think? |
I think it's good to reduce the number of data points and structure the data better. From a radar point of view, permitivity and permeabilty are also fine. |
Change file extension from xomlt to xompt to keep the p for property in there. Other than that this PR is ready to be merged. |
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
I added all discussed changes. @drsftx73 @KimuraDIVP @AsamDiegoSanchez please formally approve so we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
Signed-off-by: Diego Sánchez [email protected]
Describe your changes
Issue ticket number and link
Closes #44
Closes #45
Closes #47
Closes #49
Checklist before requesting a review