Add electromagnetic_properties_uri #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
|
@KimuraDIVP, @DavidJRitter904, @SandroReith, @drsftx73 what do you think? |
|
I think it's good to reduce the number of data points and structure the data better. From a radar point of view, permitivity and permeabilty are also fine. |
|
Change file extension from xomlt to xompt to keep the p for property in there. Other than that this PR is ready to be merged. |
ClemensLinnhoff
commented
Sep 4, 2024
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
|
I added all discussed changes. @drsftx73 @KimuraDIVP @AsamDiegoSanchez please formally approve so we can merge. |
ClemensLinnhoff
requested review from
AsamDiegoSanchez,
KimuraDIVP and
drsftx73
and removed request for
Nicolas-Beaugerard
KimuraDIVP
approved these changes
Sep 6, 2024
drsftx73
approved these changes
Sep 9, 2024
AsamDiegoSanchez
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Closes #44
Closes #45
Closes #47
Closes #49
Checklist before requesting a review