Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace C++ based TextReport module with Python implementation #115

Open
andreaskern74 opened this issue Aug 1, 2024 · 1 comment
Open

Replace C++ based TextReport module with Python implementation #115

andreaskern74 opened this issue Aug 1, 2024 · 1 comment
Labels
effort:Medium isState:Accepted An issue that has been accepted by the group, which needs to be assigned to a responsible isType:FeatureImprovement An issue that amends or improves existing features.
Milestone
Wish List

Comments

@andreaskern74
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Currently

  • There is an example how to implement a text report module in our Python base library.
  • Maintaining two implementation leads often to inconsistencies
  • Python base library has more features than the C++

Describe the solution you'd like

  • Remove C++ based solution
  • Use Python implementation directly

Not necessary at the moment. Might be useful when we need new features in the text report module or if the complete layout need to be changed.

Additional context

No reason to use C++ here, because run-time should not be a problem when doing a simple XQAR to text conversion.
@andreaskern74 andreaskern74 added isType:FeatureImprovement An issue that amends or improves existing features. isState:New A new issue that needs to be classified to a type. labels Aug 1, 2024
@andreaskern74 andreaskern74 added this to the Wish List milestone Aug 1, 2024
@andreaskern74 andreaskern74 added isState:Accepted An issue that has been accepted by the group, which needs to be assigned to a responsible and removed isState:New A new issue that needs to be classified to a type. labels Sep 12, 2024
@markuspi markuspi mentioned this issue Sep 16, 2024
Open
@hoangtungdinh hoangtungdinh mentioned this issue Sep 25, 2024
Closed
3 tasks
@MatteoRagni MatteoRagni mentioned this issue Oct 1, 2024
Open
3 tasks
@MatteoRagni
Copy link
Collaborator

A python implementation for Text Formatter has been included in #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort:Medium isState:Accepted An issue that has been accepted by the group, which needs to be assigned to a responsible isType:FeatureImprovement An issue that amends or improves existing features.
Projects
None yet
Milestone
Wish List
Development

No branches or pull requests
2 participants
@MatteoRagni @andreaskern74