-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds optional Json Format Report module #188
Adds optional Json Format Report module #188
Conversation
This commit introduces a new optional (and disabled by default) report format module for JSON file. Really similar to the Text Report module, uses nlohmann-json as dependency which is obtained automatically by CMake via `FetchContent`. To enable compilation of the module a specific option (`ASAM_QC_JSON_REPORT_FORMAT_ENABLE`) should be enabled in CMake at configuration time. Side note, adding `.vscode` as ignored directory for the project. Signed-off-by: Matteo Ragni <[email protected]>
@hoangtungdinh error in build for Linux Bare is related to XODR bundle. Do you know why it is raising while executing? I actually can reproduce the error on my machine. Should I open an issue? |
@MatteoRagni , thanks for the PR. The error was because we refactored the checker bundles to follow the new architecture of "one checker per rule" (see #163). The configurations for the tests on the main branch are therefore outdated and not compatible with the latest checker bundles. Can you rebase your PR on top of https://github.com/asam-ev/qc-framework/tree/2024-09-25, which will be merged tomorrow. This branch contains the updated configuration for the new checker bundles. |
I think this JSON Format Report is definitely useful. What do you think about implementing it in Python @MatteoRagni ? Given the functionality of this module, a Python implementation seems trivial (a lot of effort goes into the schema, which can be reused). Having it in Python would simplify installation and manifest file registration a lot (just Here are some related issues: |
|
This commit introduces a new optional (and disabled by default) report format module for JSON file. Really similar to the Text Report module, uses nlohmann-json as dependency which is obtained automatically by CMake via `FetchContent`. To enable compilation of the module a specific option (`ASAM_QC_JSON_REPORT_FORMAT_ENABLE`) should be enabled in CMake at configuration time. Side note, adding `.vscode` as ignored directory for the project. Signed-off-by: Matteo Ragni <[email protected]>
…into antemotion-mr/json-format
Description
This commit introduces a new optional (and disabled by default) report format module for JSON file. Really similar to the Text Report module, uses nlohmann-json as dependency which is obtained automatically by CMake via
FetchContent
.To enable compilation of the module a specific option (
ASAM_QC_JSON_REPORT_FORMAT_ENABLE
) should be enabled in CMake at configuration time.Side note, adding
.vscode
as ignored directory for the project.Main changes
How was the PR tested?
Notes
Adding
.vscode
as ignored directory (.gitignore
)