Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maintenance work #104

Merged
merged 11 commits into from
Sep 26, 2024
Merged

Add maintenance work #104

merged 11 commits into from
Sep 26, 2024

Conversation

hoangtungdinh
Copy link
Contributor

@hoangtungdinh hoangtungdinh commented Sep 25, 2024 •
edited
Loading

Description

This PR includes various maintenance tasks.

Main changes

  1. Improve robustness in parsing numbers
  2. Add inertial point to horizontal smoothness issues
  3. Refactor to use one checker per rule
  4. Output file location in schema issues
  5. Add summary to result file
  6. Refactor and clean up the architecture
  7. Fix an issue message
  8. Add sample files for future rule implementations

How was the PR tested?

  1. Tests are documented in each PR

Notes

This PR closes the following issues

@hoangtungdinh hoangtungdinh added the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Sep 25, 2024
hoangtungdinh and others added 8 commits September 25, 2024 11:49
@hoangtungdinh
Improve robustness in parsing numbers (#95)
bfd83d2 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@patrickpa @hoangtungdinh
Add inertial point to horizontal smoothness check (#96)
2614952 
Signed-off-by: patrickpa <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
@hoangtungdinh
Refactor to use one checker per rule (#97)
7c704b6 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Output file location when schema check outputs errors (#98)
759db94 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Add summary to result file (#99)
f7439ed 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Add exception logging (#100)
0ddd278 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Use new functions from baselib (#102)
cab3908 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@patrickpa @hoangtungdinh
Fix road new lane appear issue message to take linkage tag into accou…
fc9ba19 
…nt (#103)

Signed-off-by: patrickpa <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
hoangtungdinh and others added 3 commits September 25, 2024 16:29
@hoangtungdinh
Lower the required version of xmlschema to 3.3.1 (#105)
cefa406 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Add sample files (#106)
8ffb846 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Reorganize folder for not implemented yet test files (#107)
56833be 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@AsamDiegoSanchez
Copy link
Member

in CCB reviewed. Ready for merge

@AsamDiegoSanchez AsamDiegoSanchez added isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager and removed isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok labels Sep 26, 2024
AsamDiegoSanchez
AsamDiegoSanchez approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in CCB reviewed. Ready for merge
Signed-off by: Diego Sánchez[email protected]

@andreaskern74 andreaskern74 merged commit 2fe8422 into main Sep 26, 2024
7 checks passed
@andreaskern74 andreaskern74 deleted the 2024-09-25 branch September 26, 2024 14:03
@andreaskern74 andreaskern74 added isState:Integrated An issue that has been integrated and has an integration reviewer and removed isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager labels Sep 26, 2024
@AsamDiegoSanchez AsamDiegoSanchez mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsamDiegoSanchez AsamDiegoSanchez AsamDiegoSanchez approved these changes

Assignees
No one assigned
Labels
isState:Integrated An issue that has been integrated and has an integration reviewer
Projects
Quality Checker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoangtungdinh @AsamDiegoSanchez @andreaskern74 @patrickpa