Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCB Review: Prepare v1.0.0-rc.1 release candidate #111

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

hoangtungdinh
Copy link
Contributor

@hoangtungdinh hoangtungdinh commented Oct 7, 2024

Description

This PR prepares for the release candidate 1.0.0rc1. After this PR is merged into main, the tag v1.0.0-rc1 will be created and the Python package asam-qc-opendrive 1.0.0rc1 will be published to PyPi.

Main changes

  1. Add release disclaimer
  2. Remove the optional argument build_date when registering checker bundle
  3. Add documentation about how to implement new checkers
  4. Add quotation to example windows manifest to handle spaces (Files in directory containing a whitespace don't work when calling ResultPooling, no end result and reporting qc-framework#189)
  5. Use asam-qc-baselib from the official PyPi server with the version range ^1.0.0rc1
  6. Use typing.Optional instead of Union[None, ...].
  7. Fix an issue in the new lane appear rule as described in wrong message for check_asam_xodr_road_lane_link_new_lane_appear #112

How was the PR tested?

  1. Tests are documented in each PR below.
  2. Unit tests.

Notes

A test release in the Test PyPi server is available here.

hoangtungdinh and others added 2 commits October 7, 2024 15:27
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@hoangtungdinh hoangtungdinh added the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Oct 7, 2024
Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed
Signed-off by: Diego Sánchez [email protected]

@MircoNierenz MircoNierenz requested review from MircoNierenz and removed request for MircoNierenz October 11, 2024 10:06
@andreaskern74 andreaskern74 merged commit d275311 into main Oct 11, 2024
7 checks passed
@andreaskern74 andreaskern74 deleted the 2024-10-07 branch October 11, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants