Skip to content

Commit

Permalink
Prepare for release candidate v1.0.0-rc.1
Browse files Browse the repository at this point in the history
Signed-off-by: hoangtungdinh <[email protected]>
  • Loading branch information
hoangtungdinh committed Oct 2, 2024
1 parent ede73bd commit d4370a4
Show file tree
Hide file tree
Showing 6 changed files with 46 additions and 13 deletions.
33 changes: 33 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ This project implements the [OTX Checker Bundle](checker_bundle_doc.md) for the
The ASAM Quality Checker OTX library contains a short representative list of check examples for [Open Test sequence eXchange (OTX)](https://report.asam.net/otx-iso-13209-open-test-sequence-exchange-format)
to showcase the functionality and implementation (it shall not be a reference implementation) for the ASAM Quality Checker project.

**Disclaimer**: The current version is a release candidate. The first official release is expected to be in November.

- [asam-qc-otx](#asam-qc-otx)
- [Installation and usage](#installation-and-usage)
- [Installation using pip](#installation-using-pip)
Expand Down Expand Up @@ -184,3 +186,34 @@ You need to have pre-commit installed and install the hooks:
```
pre-commit install
```

**To implement a new checker:**

1. Create a new Python module for each checker.
2. Specify the following global variables for the Python module

| Variable | Meaning |
| --- | --- |
| `CHECKER_ID` | The ID of the checker |
| `CHECKER_DESCRIPTION` | The description of the checker |
| `CHECKER_PRECONDITIONS` | A set of other checkers in which if any of them raise an issue, the current checker will be skipped |
| `RULE_UID` | The rule UID of the rule that the checker will check |

3. Implement the checker logic in the following function:

```python
def check_rule(checker_data: models.CheckerData) -> None:
pass
```

4. Register the checker module in the following function in [main.py](qc_otx/main.py).

```python
def run_checks(config: Configuration, result: Result) -> None:
...
# Add the following line to register your checker module
execute_checker(your_checker_module, checker_data)
...
```

All the checkers in this checker bundle are implemented in this way. Take a look at some of them before implementing your first checker.
3 changes: 2 additions & 1 deletion checker_bundle_doc.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
# Checker bundle: otxBundle

* Build version: 0.1.0
* Build version: v1.0.0-rc.1
* Description: OTX checker bundle

## Parameters

* InputFile
* resultFile

## Checkers

Expand Down
18 changes: 9 additions & 9 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "asam-qc-otx"
version = "0.1.0"
version = "1.0.0rc1"
description = "This project implements the Open Test sequence eXchange Checker for the ASAM Quality Checker project."
authors = ["Danilo Romano <[email protected]>"]
license = "MPL-2.0"
Expand Down
2 changes: 1 addition & 1 deletion qc_otx/constants.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
BUNDLE_NAME = "otxBundle"
BUNDLE_VERSION = "0.1.0"
BUNDLE_VERSION = "v1.0.0-rc.1"
1 change: 0 additions & 1 deletion qc_otx/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ def main():
result = Result()
result.register_checker_bundle(
name=constants.BUNDLE_NAME,
build_date=datetime.today().strftime("%Y-%m-%d"),
description="OTX checker bundle",
version=constants.BUNDLE_VERSION,
summary="",
Expand Down

0 comments on commit d4370a4

Please sign in to comment.