code cleanup for MidiMonitor #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Pascal,
Now I am sending the one of the parts after splitting the simplified AlignedBuf, corrected dexedTheme, code purification related to MidiMonitor #434 in this PR; it contains only the corrections related to
MidiMonitorclass.Unfortunately, another issue has arisen regarding DexedTheme (the build-macos step failed), so there is still work to be done there.
Furthermore, I have not yet found a good and general solution for
AlignedBufthat would extend to older C++ compilers as well.So for now, I’m just sending only this single PRs, (hoping that it can pass without further new tricky problems.)
Thank you for your patience!