Credentials unit tests

resources/lib/NetflixCredentials.py

@@ -21,7 +21,7 @@ def encode_credentials(self, email, password):
             The users stored account data
         """
         # if everything is fine, we encode the values
-        if '' != email or '' != password:
+        if '' != email and '' != password:
             return {
                 'email': self.encode(raw=email),
                 'password': self.encode(raw=password)
@@ -42,7 +42,7 @@ def decode_credentials(self, email, password):
             The users stored account data
         """
         # if everything is fine, we decode the values
-        if (email and '' != email) or (password and '' != password):
+        if (email and '' != email) and (password and '' != password):
             return {
                 'email': self.decode(enc=email),
                 'password': self.decode(enc=password)

resources/test/test_NetflixCredentials.py

@@ -0,0 +1,78 @@
+# -*- coding: utf-8 -*-
+# Module: NetflixCredentials
+# Author: tomjshore
+# Created on: 20.08.2019
+# License: MIT https://goo.gl/5bMj3H
+
+"""Testing for NetflixCredentials"""
+
+import unittest
+from resources.lib.NetflixCredentials import NetflixCredentials
+
+class NetflixCredentialsTestCase(unittest.TestCase):
+
+    def test_can_encode_and_decode_email_and_password(self):
+        email = 'tom'
+        password = 'rubbish password'
+        cred = NetflixCredentials()
+        encoded = cred.encode_credentials(email, password)
+        decoded = cred.decode_credentials(encoded['email'], encoded['password'])
+
+        self.assertEqual(email, decoded['email'])
+        self.assertEqual(password, decoded['password'])
+        self.assertNotEqual(email, encoded['email'])
+        self.assertNotEqual(password, encoded['password'])
+
+    def test_empty_email_will_not_encode(self):
+        email = ''
+        password = 'rubbish password'
+        cred = NetflixCredentials()
+        encoded = cred.encode_credentials(email, password)
+
+        self.assertEqual('', encoded['email'])
+        self.assertEqual('', encoded['password'])
+
+    def test_empty_password_will_not_encode(self):
+        email = 'tom'
+        password = ''
+        cred = NetflixCredentials()
+        encoded = cred.encode_credentials(email, password)
+
+        self.assertEqual('', encoded['email'])
+        self.assertEqual('', encoded['password'])
+
+    def test_empty_email_and_password_will_not_encode(self):
+        email = ''
+        password = ''
+        cred = NetflixCredentials()
+        encoded = cred.encode_credentials(email, password)
+
+        self.assertEqual('', encoded['email'])
+        self.assertEqual('', encoded['password'])
+
+    def test_empty_email_will_not_decode(self):
+        cred = NetflixCredentials()
+        email = ''
+        password = cred.encode('rubbish password')
+        decoded = cred.decode_credentials(email, password)
+
+        self.assertEqual('', decoded['email'])
+        self.assertEqual('', decoded['password'])
+
+    def test_empty_password_will_not_decode(self):
+        cred = NetflixCredentials()
+        email = cred.encode('tom')
+        password = ''
+        decoded = cred.decode_credentials(email, password)
+
+        self.assertEqual('', decoded['email'])
+        self.assertEqual('', decoded['password'])
+
+    def test_empty_email_and_password_will_not_decode(self):
+        cred = NetflixCredentials()
+        email = ''
+        password = ''
+        decoded = cred.decode_credentials(email, password)
+
+        self.assertEqual('', decoded['email'])
+        self.assertEqual('', decoded['password'])