Add easy build and execution instructions for developers #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayowel
force-pushed
the
feature/easy-dev-startup
branch
2 times, most recently
from
0d765df
to
c7ce5da
Compare
|
It is pretty clear changes, thank you! I changed the target branch to development from master. There is a small conflict in pom.xml, could you please resolve the conflicts ? |
Ayowel
force-pushed
the
feature/easy-dev-startup
branch
from
70cf7ef
to
4338d9d
Compare
|
Just rebased on development. Should be good for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting-up JavaFX is a pain the first time and making it easier for new users to build Asciidocfx should encourage potential maintainers to send a fix.
This PR adds the plugin that should be used to run javafx applications locally (https://openjfx.io/openjfx-docs/maven) with maven as well as instructions to use it with minimal setup requirements.
EDIT : added a second commit to set jvm args from maven properties. It reuses what is already defined for the compiled published version to avoid future maintenance issues of both parameter sets.