Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(use-case/nodecli): ESModule対応 #1465
fix(use-case/nodecli): ESModule対応 #1465
Changes from 17 commits
3a132ff
9d34858
2b26d8e
60e5a50
bdc6d25
262521f
43a291e
ec895b2
d4609a4
74028ee
cb4b91e
faed2a0
eb98a37
5b2d30e
bb6082b
b8c0693
d87b4a7
aecdae4
8303765
df3adaa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これあんまり意識してなかったけど、確かにそうなってた。
https://github.com/nodejs/node/tree/main/lib
前提として、Node.jsの標準モジュール自体がCJSで書かれてることが抜けている感じがする。
なんか別の例でもいいのかなーとはちょっと思ったけど、思いついてない。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
標準モジュールのことは125行目でさらっと書いてますね
This file was deleted.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.