-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 「Math」のまとめの接続表現を修正 #1612
Open
morinokami
wants to merge
1
commit into
asciidwango:master
Choose a base branch
from
morinokami:patch-24
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: 「Math」のまとめの接続表現を修正 #1612
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
普通に読んでいて、〜でしかないため 相当な意味合いかなと思いました。
「に過ぎない(にすぎない)」の意味や使い方 わかりやすく解説 Weblio辞書
どちらでも通じるかなとは思いました。
紹介したのは一部分でしかない → そのため他にもメソッドがあります。
変更後は、そのほかの方が重要っぽくは見えました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
自分が引っかかっていたのは「ため」という語で、自分の感覚としてはこれが接続する前後の文は内容的に異なることが通常だと思います。たとえば「電車が遅れているため遅刻します」のような感じです。
一方、ここで修正した文の中の「ため」の前後を見てみると
Math
オブジェクトの一部にすぎないとほぼ同内容の言い換え表現となっており、通じるかどうかで言えば通じると思うのですが、少し違和感があり PR を作成しました。
この点については自分は感じていませんでしたが、「にすぎない」という語は「大したことがない」というニュアンスで使われることも確かにあると思うので、そうした感じが出てしまっているのかもしれませんね。
のように「にすぎない」を使わないのが良いのかもしれません。