Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Add optional hardware texture rendering on Android #112

Merged
merged 2 commits into from
May 18, 2020

Conversation

alexandrius
Copy link
Contributor

This is useful if you want to rotate the rendered image. If renderToHardwareTextureAndroid is enabled image frame cuts of the content for image rotated with transform.

These are screenshots for both enabled and disabled renderToHardwareTextureAndroid
https://imgur.com/a/0ucJbtW

@ArtemKolichenkov
Copy link
Collaborator

Thanks for the contribution!
This actually closes #106

Unfortunately this PR has conflicts now. Can you resolve it? 🙂

I will apply your fix myself in case you don't follow this repo anymore (trying to fix bugs ASAP here, read #129 if interested). Though I will make sure to mark your contributions once I have allcontributors bot installed in this repo.

@alexandrius
Copy link
Contributor Author

alexandrius commented May 18, 2020

@ArtemKolichenkov Fixed

@ArtemKolichenkov
Copy link
Collaborator

Great! Merging this :)

@alexandrius
Copy link
Contributor Author

@ArtemKolichenkov Any chance of updating https://github.com/ascoders/react-native-image-viewer with updated react-native-image-zoom?

@ArtemKolichenkov
Copy link
Collaborator

@alexandrius yes. I will do it as soon as I have time, which is either later today or tomorrow :)

@ArtemKolichenkov
Copy link
Collaborator

@all-contributors please add @alexandrius for code

@allcontributors
Copy link
Contributor

@ArtemKolichenkov

I've put up a pull request to add @alexandrius! 🎉

@ArtemKolichenkov
Copy link
Collaborator

@alexandrius just released https://github.com/ascoders/react-native-image-viewer v 3.0.1 with updates from this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants