This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Allow zero for duration
parameter for centerOn method
#158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! First of all, thanks for maintaining this cool project! 💪
This pull request aims to allow developers to specify
0
as a valid value for theduration
parameter passed tocenterOn
method. Currently, specifying0
leads to having300
as a fallback value due to the fact that zero is treated as a falsy value, thus the expression0 || 300
returns300
. In our use case, it is required just to show part of the big image, and animation is unnecessary in the scenario we try to implement. My intuition was to just specify zero for theduration
parameter, but it didn't work. To achieve the desired outcome I currently need to specify1
or0.1
as animation duration, which is, in my opinion, might be a bit confusing for newcomers.I think we could utilize nullish coalescing here. Luckily, there's no additional configuration required as TypeScript 3.9.2 already supports it.
Please, let me know what do you think about this!