Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add typescript definitions #25

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat: add typescript definitions #25

wants to merge 6 commits into from

Conversation

andreidmt
Copy link
Collaborator

@andreidmt andreidmt commented Nov 8, 2022 •
edited by dgilperez
Loading

The goal is to give m Typescript support. We achieve this by manually creating .d.ts files instead of rewriting the code from JS to TS.

Code changes

  1. Install tsd for testing types
  2. Add build.types and test.types npm scripts
  3. Add types folder with TS helpers
  4. Add types for all, allWith, map, i, pipe, curry

Checklist

  • Code tests
  • Type tests
  • JSDocs
  • Export in src/index.js
  • Export type in src/index.d.ts

@dgilperez dgilperez mentioned this pull request Dec 8, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andreidmt