Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS build: upgrade to latest direnv #191

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Aug 20, 2024

A few months ago, our GitHub actions started running on arm macOS
machines 0. However, direnv v2.23.1 doesn't actually have an arm
release for macos:
https://github.com/direnv/direnv/releases/tag/v2.23.1. direnv started
uploading prebuild darwin-amd64 images in v2.28.0:
https://github.com/direnv/direnv/releases/tag/v2.28.0. I opted to just
upgrade us to the latest version while I'm in here.

@jfly jfly force-pushed the jfly/debug-macos-build-failures branch from bdeb192 to 8fd3282 Compare August 20, 2024 20:25
@jfly jfly requested a review from a team as a code owner August 20, 2024 20:25
@jfly jfly force-pushed the jfly/debug-macos-build-failures branch 3 times, most recently from eef819e to 411bc31 Compare August 20, 2024 20:38
@jfly jfly changed the title WIP: Debugging recent macOS build failures Fix macOS build: upgrade to latest direnv Aug 20, 2024
A few months ago, our GitHub actions started running on arm macOS
machines [0]. However, direnv v2.23.1 doesn't actually have an arm
release for macos:
https://github.com/direnv/direnv/releases/tag/v2.23.1. direnv started
uploading prebuild darwin-amd64 images in v2.28.0:
https://github.com/direnv/direnv/releases/tag/v2.28.0. I opted to just
upgrade us to the latest version while I'm in here.

[0]: https://www.reddit.com/r/github/comments/1cjiat4/is_github_actions_macoslatest_now_only_armbased/
@jfly jfly force-pushed the jfly/debug-macos-build-failures branch from 411bc31 to b299d27 Compare August 20, 2024 20:41
@jfly
Copy link
Contributor Author

jfly commented Aug 20, 2024

Merging this to unbreak the build!

@jfly jfly merged commit df21a56 into master Aug 20, 2024
12 checks passed
@jfly jfly deleted the jfly/debug-macos-build-failures branch August 20, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant