Fix: Install not working when jq is not already installed #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to run |
I tested it again right now, and you don't need to install jq yourself with these changes. |
|
@oae is there anything wrong with this? |
|
@oae hey, would you be able to review this PR? It's a great addition to the plugin, makes using this in a CI context a lot simpler. Thank you for making this plugin! |
|
I think @oae is not actively maintaining this anymore. He is looking for maintainers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
installcommand tried to use the system native jq instead of the one downloaded by this plugin. This resulted in a crash when jq was not installed locally.