fix: make plugin-test work on alpine linux#1778
Merged
Stratus3D merged 2 commits intoasdf-vm:masterfrom Dec 16, 2024
vic1707:patch-1
Merged
fix: make plugin-test work on alpine linux#1778Stratus3D merged 2 commits intoasdf-vm:masterfrom vic1707:patch-1
Stratus3D merged 2 commits intoasdf-vm:masterfrom
vic1707:patch-1
Conversation
vic1707
changed the title
Member
|
Thanks for the PR @vic1707 ! I think this is worth merging. |
Member
|
Merging now as I've already got a fix for the failing build on #1806. |
Stratus3D
approved these changes
Dec 16, 2024
Stratus3D
added a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: Trevor Brown <Stratus3D@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the alpine (busbox) version of
mktempexpects templates to end with exactly 6 Xs whereas GNU want at least 3.Bumping to 6 Xs allows alpine users to run the plugin-test command without installing the
coreutilspackage firstOther Information
On alpine anything with less than 6 Xs is an error
On ubuntu it doesn't matter if its 4 or 6
It will also fix running the
asdf-vm/actions/plugin-testactions on an alpine container (for now anapk add coreutilsis required)