Skip to content

Use definitions from stdint.h instead define uintXX_t by hand #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use definitions from stdint.h instead define uintXX_t by hand #224

wants to merge 1 commit into from

Conversation

ziyao233
Copy link

@ziyao233 ziyao233 commented May 31, 2025 •
edited
Loading 

    These hand-written definitions don't compile on some platforms like
    musl since u_intXX_t (with two underscores) types aren't standard. As
    stdint.h already contains defintions for uintXX_t types, there's no
    reason to define them manually. Let's clean them up.

@ziyao233 ziyao233 marked this pull request as draft May 31, 2025 15:45
@ziyao233
Copy link
Author

I originally intended to test the change in CI of my local repository and this PR is opened by mistake, Will polish my change and mark the PR ready for review when it's really done.

Sorry for the noise.

@ziyao233
Use definitions from stdint.h instead define uintXX_t by hand
8d7daeb 
These hand-written definitions don't compile on some platforms like
musl since u_intXX_t (with two underscores) types aren't standard. As
stdint.h already contains defintions for uintXX_t types, there's no
reason to define them manually. Let's clean them up.

Signed-off-by: Yao Zi <[email protected]>
@ziyao233 ziyao233 force-pushed the musl/fix-u_intxx_t-definition branch from 6ef31d4 to 8d7daeb Compare May 31, 2025 15:56
@ziyao233 ziyao233 changed the title stdint.h should already do the job Use definitions from stdint.h instead define uintXX_t by hand May 31, 2025
@ziyao233
Copy link
Author

ziyao233 commented May 31, 2025 •
edited
Loading

Oops, it's a duplication of #219. I'm closing it. Really sorry for the inconvenience.

@ziyao233 ziyao233 closed this May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ziyao233