Add lua binding #237
Open
Add lua binding #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+16
to
+17
| echo "Error: lsqlite3 module is not installed" | ||
| echo "Install it with: luarocks install lsqlite3" |
There was a problem hiding this comment.
Maybe it would be better to print errors to stderr:
Suggested change
| echo "Error: lsqlite3 module is not installed" | |
| echo "Install it with: luarocks install lsqlite3" | |
| echo "Error: lsqlite3 module is not installed" >&2 | |
| echo "Help: luarocks install lsqlite3" >&2 |
|
Great contribution, I hope it gets reviewed ❤️ Would a small unit test be possible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lua binding and examples/simple-lua as demo.