Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPIframe incorrect response mode param #162

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

brionmario
Copy link
Member

Purpose

Response mode query is send with a wrong casing to the RPIframe's prompt=none authorize request.

Screenshot 2024-01-18 at 12 05 35

Reason

This seems to have been introduced with 8b77734 change, and it was previously working fine due to the authparam transformation(https://github.com/asgardeo/asgardeo-auth-js-core/pull/203/files#diff-f34c1fc70c8dfe6982556af3ab69b70a42b7a68c9119cfa0bfa4716acd929750R120). This was removed with asgardeo/asgardeo-auth-react-sdk#208.

Goals

Approach

  • Change responseMode to response_mode.

User stories

N/A

Release note

N/A

Documentation

N/A

Training

N/A

Certification

N/A

Marketing

N/A

Automation tests

  • Unit tests
    • N/A
  • Integration tests
    • N/A

Security checks

Samples

N/A

Related PRs

  • TODO

Migrations (if applicable)

N/A

Test environment

N/A

Learning

N/A

@brionmario brionmario reopened this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect responseMode param is sent in RPIframe's prompt=none authorize request
2 participants