Remove isAuthenticated check that is executed before signout #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavinduLakshan
requested review from
brionmario,
NipuniBhagya,
inthirakumaaran and
jeradrutnam
as code owners
pavinduLakshan
requested review from
yathindrak and
DonOmalVindula
and removed request for
jeradrutnam,
inthirakumaaran,
brionmario and
NipuniBhagya
brionmario
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It's not necessary to execute
isAuthenticatedcheck before signing out, but the SDK does run check prior executing the signOut method.Note: sending id token hint as a parameter will not be affected by this change, as the ID token is taken from the session storage and it is not cleared on session timeout.
Related issues