Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: there are several react-hooks/exhaustive-deps violations #42

Open
brionmario opened this issue Jul 5, 2024 · 0 comments
Open

fix: there are several react-hooks/exhaustive-deps violations #42

brionmario opened this issue Jul 5, 2024 · 0 comments

Comments

@brionmario
Copy link
Member

brionmario commented Jul 5, 2024

Description:

There are several react-hooks/exhaustive-deps violations in the @asgardeo/react package.

/home/runner/work/web-ui-sdks/web-ui-sdks/packages/react/src/components/SignIn/SignIn.tsx
    114:6  error  React Hook useEffect has a missing dependency: 'authContext'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  
  /home/runner/work/web-ui-sdks/web-ui-sdks/packages/react/src/hooks/use-on.ts
    [41](https://github.com/asgardeo/web-ui-sdks/actions/runs/9806802898/job/27079282605?pr=41#step:9:44):6  error  React Hook useEffect has missing dependencies: 'callback', 'contextValue', and 'event'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
  
  /home/runner/work/web-ui-sdks/web-ui-sdks/packages/react/src/hooks/use-translations.ts
    52:6  error  React Hook useEffect has a missing dependency: 'setIsTextLoading'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
    56:6  error  React Hook useEffect has a missing dependency: 'setIsTextLoading'. Either include it or remove the dependency array  react-hooks/exhaustive-deps   

Suggested Labels:

  • N/A

Suggested Assignees:

  • N/A

Affected Product Version:

  • N/A

OS, DB, other environment details and versions:

  • N/A

Steps to reproduce:

  • N/A

Related Issues:

  • N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant