Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint & code formatter issues #41

Merged
merged 8 commits into from
Jul 5, 2024

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Jul 5, 2024

Purpose

Eslint doesn't really work in the @asgardeo/react package.

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@brionmario
Copy link
Member Author

brionmario commented Jul 5, 2024

TODO: Need to fix these react-hooks/exhaustive-deps issues.

/home/runner/work/web-ui-sdks/web-ui-sdks/packages/react/src/components/SignIn/SignIn.tsx
    114:6  error  React Hook useEffect has a missing dependency: 'authContext'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  
  /home/runner/work/web-ui-sdks/web-ui-sdks/packages/react/src/hooks/use-on.ts
    [41](https://github.com/asgardeo/web-ui-sdks/actions/runs/9806802898/job/27079282605?pr=41#step:9:44):6  error  React Hook useEffect has missing dependencies: 'callback', 'contextValue', and 'event'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
  
  /home/runner/work/web-ui-sdks/web-ui-sdks/packages/react/src/hooks/use-translations.ts
    52:6  error  React Hook useEffect has a missing dependency: 'setIsTextLoading'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
    56:6  error  React Hook useEffect has a missing dependency: 'setIsTextLoading'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

@brionmario brionmario merged commit 97048ba into asgardeo:main Jul 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants