feat(core): add me & expose functions and models #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movinsilva
force-pushed
the
js-ui-core--me
branch
from
d171a68
to
7f7d88a
Compare
packages/core/src/api/profile.ts
Outdated
Comment on lines
28
to
41
| try { | ||
| baseUrl = (await AuthClient.getInstance().getDataLayer().getConfigData()).baseUrl; | ||
| accessToken = await AuthClient.getInstance().getAccessToken(); | ||
| } catch (error) { | ||
| throw new AsgardeoUIException( | ||
| 'JS_UI_CORE-ME-M-NF', | ||
| 'Failed in getting the base URL and access token.', | ||
| error.stack, | ||
| ); | ||
| } | ||
|
|
||
| if (!accessToken) { | ||
| throw new AsgardeoUIException('JS_UI_CORE-ME-M-IV', 'Access token is null.'); | ||
| } |
There was a problem hiding this comment.
Shall we extract this logic to a reusable function? Retrieving the access token is going to be reused by many methods I guess.
Ideally, it should be the end users responsibility to pass the correct payload and headers to getProfileInformation function. The SDK should not make token requests for each API call, IMO.
There was a problem hiding this comment.
In the core SDK, only this function is getting the access token. So retrieving access token won't be reused.
End user will be accessing either a custom hook to get user information or will use the profile component directly. In these scenarios we cannot expect the the end user to pass any payload or headers, as it will degrade the user experience.
pavinduLakshan
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issues
Related PRs
Checklist
Security checks