fix: return skipped upserts in bulk_create #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabasJ
changed the title
zachdaniel
reviewed
Oct 1, 2025
lib/data_layer.ex
Outdated
| else | ||
| # TODO: what if there are less results than changesets because of upsert conditions? | ||
| {:ok, | ||
| Stream.zip_with(results, changesets, fn result, changeset -> |
There was a problem hiding this comment.
Your comment here is interesting. Yeah I think we may need to get the appropriate changeset by looking at the identity values from the changesets similarly to what you're doing above.
barnabasJ
force-pushed
the
fix/return-skipped-records-bulk-create
branch
from
6c624e4 to
58dd9d2
Compare
zachdaniel
approved these changes
Oct 3, 2025
barnabasJ
force-pushed
the
fix/return-skipped-records-bulk-create
branch
from
ae0e811 to
0c80433
Compare
|
LMK when this is ready for re-review 🙇 |
Should be ready. The failing test is from main |
zachdaniel
approved these changes
Oct 14, 2025
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
extra context
Requires an Ash version upgrade to make the test pass.