Simplify AddUsersToGroup Query

Co-authored-by: Joel Smith <[email protected]>

Author: Tyler Noblett

backend/services/user_groups.go

@@ -77,32 +77,24 @@ func (i CreateUserGroupInput) validateUserGroupInput() error {
 }
 
 func AddUsersToGroup(tx *database.Transactable, userSlugs []string, groupID int64) error {
-	if len(userSlugs) > 0 {
-		questionMarks := "("
-
-		interfaceSlice := make([]interface{}, len(userSlugs)+1)
-		for i, v := range userSlugs {
-			questionMarks += "?, "
-			interfaceSlice[i] = v
-		}
+	if len(userSlugs) == 0 {
+		return nil
+	}
 
-		questionMarks = strings.TrimSuffix(questionMarks, ", ")
-		questionMarks += ")"
+	peopleToAdd := sq.Select("id", strconv.FormatInt(groupID, 10)).
+		From("users").
+		Where(sq.Eq{"slug": userSlugs})
 
-		sqlStatement := fmt.Sprintf(`INSERT IGNORE INTO group_user_map(user_id, group_id)
-					SELECT users.id, user_groups.id
-					FROM users, user_groups
-					WHERE users.slug in %s and user_groups.id = ?;`, questionMarks)
+	insertQuery := sq.
+		Insert("group_user_map").
+		Options("Ignore").
+		Columns("user_id", "group_id").Select(peopleToAdd)
 
-		interfaceSlice[len(userSlugs)] = groupID
-		err := tx.Exec(sq.Expr(sqlStatement, interfaceSlice...))
+	err := tx.Exec(insertQuery)
 
-		if err != nil {
-			return backend.WrapError("Unable to add users to group", backend.DatabaseErr(err))
-		}
-		return nil
+	if err != nil {
+		return backend.WrapError("Unable to add users to group", backend.DatabaseErr(err))
 	}
-
 	return nil
 }