Fix inverted bit 1 polarity in screen control register - #26
Open
jmolleda wants to merge 1 commit into
Open
Conversation
….0.4 Bit 1 of the screen control register was inverted: setting it to 1 turned the screen on instead of off. Writing 0x0001 (clear) would unintentionally power off the screen. Corrected isOn, powerOn, powerOff, and reset to match the spec. Added 4 tests covering all bit 0/bit 1 combinations. Fixed existing test 'Test powered off no characters' which used 0x0003 expecting screen ON, but bit 1 = 1 means OFF per spec — this test fails on main without this fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jmolleda
force-pushed
the
fix/screen-control-register-polarity
branch
from
March 18, 2026 17:27
7924e26 to
1cacdd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test powered off no characterswhich used 0x0003 expecting screen ON, but bit 1 = 1 means OFF per spec — this test fails on main without this fixTest plan
🤖 Generated with Claude Code