-
Notifications
You must be signed in to change notification settings - Fork 0
use mise more #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR shifts the toolchain focus from Devbox to Mise by updating configuration files, documentation, and setup scripts. Key changes include:
- Replacing simple defer calls with cleanup functions that log errors in WASM module bindings.
- Introducing and updating various scripts and configuration files to utilize Mise for managing dependencies.
- Removing outdated Devbox configuration and related files.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| template/{{"go-wasm" if include_go else "skip_go_wasm"}}/go/binding.go.jinja | Updated WASM module cleanup to log errors instead of silently closing. |
| template/scripts/dev-setup.sh | Added a setup script that installs Mise if missing. |
| template/mise.toml.jinja | Removed in favor of the updated configuration in mise.toml. |
| template/mise.toml | New configuration file specifying toolchain versions and tools. |
| template/devbox.json | Removed outdated Devbox configuration. |
| template/Justfile.jinja | Removed redundant devbox install command. |
| template/.envrc | Removed outdated environment activation configuration. |
| scripts/test.sh | Added test script for project generation and setup verification. |
| scripts/dev-setup.sh | Added a standalone setup script for development environment. |
| mise.toml | Updated toolchain configuration with new copier tool support. |
| devbox.json | Removed obsolete Devbox configuration. |
| README.md | Updated instructions to reflect the new focus on Mise. |
| .clinerules | Removed outdated project guidelines. |
template/{{"go-wasm" if include_go else "__skip_go_wasm__"}}/go/binding.go.jinja
Outdated
Show resolved
Hide resolved
5af956e to
4092f2d
Compare
4092f2d to
084eacb
Compare
616aae3 to
be45ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.