-
Notifications
You must be signed in to change notification settings - Fork 6
Implement the ZeroMQ transport #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4ebc035 to
85af8a6
Compare
50647e8 to
0f5c529
Compare
|
To run tests with full tracing output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Currently CI fails due to this PR's new dependency on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit-picks that I've noticed while I was fixing CI. Didn't look thoroughly at the rest of the code but at the first glance looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is auto-generated. Maybe it makes more sense to put it in generated/-like directory and add it to .gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I explicitly configure prost-build in build.rs to output the generated files to src/ as by default they go to the build directory (target/.../) and are imported with include!(concat!(env!("OUT_DIR"), "/your.proto.package.rs")).
So unless we have a preference against it, I'd place this in src/ and commit the generated file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@race-of-sloths invite |
|
@artob Thank you for calling! @SamuelSarle Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
No description provided.