Skip to content

Conversation

@SamuelSarle
Copy link
Member

No description provided.

@SamuelSarle SamuelSarle force-pushed the samuel/impl-zmq-transport branch from 4ebc035 to 85af8a6 Compare November 29, 2024 12:15
@SamuelSarle SamuelSarle force-pushed the samuel/impl-zmq-transport branch 2 times, most recently from 50647e8 to 0f5c529 Compare November 29, 2024 12:29
@SamuelSarle
Copy link
Member Author

To run tests with full tracing output:

cd lib/protoflow-zeromq
RUST_LOG="trace" cargo test tests::run_transport -- --nocapture

@artob artob changed the title Implement ZeroMQ transport. Implement ZeroMQ transport Dec 4, 2024
@artob artob changed the title Implement ZeroMQ transport Implement the ZeroMQ transport Dec 4, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details

@SamuelSarle SamuelSarle marked this pull request as ready for review December 4, 2024 20:19
@SamuelSarle SamuelSarle requested a review from artob as a code owner December 4, 2024 20:19
@imunproductive
Copy link
Member

imunproductive commented Dec 5, 2024

Currently CI fails due to this PR's new dependency on protoc. Fixed in PR #28

Copy link
Member

@imunproductive imunproductive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit-picks that I've noticed while I was fixing CI. Didn't look thoroughly at the rest of the code but at the first glance looks good to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated. Maybe it makes more sense to put it in generated/-like directory and add it to .gitignore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly configure prost-build in build.rs to output the generated files to src/ as by default they go to the build directory (target/.../) and are imported with include!(concat!(env!("OUT_DIR"), "/your.proto.package.rs")).

So unless we have a preference against it, I'd place this in src/ and commit the generated file.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details

@artob
Copy link
Member

artob commented Jan 27, 2025

@race-of-sloths invite

@race-of-sloths
Copy link

@artob Thank you for calling!

@SamuelSarle Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants