Skip to content

Improve CI workflows #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Improve CI workflows #28

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f42a3ca
change event type to have more permissions when dealing with forks
imunproductive Dec 4, 2024
9a480e3
restrict default permissions
imunproductive Dec 4, 2024
cc0bab8
bump ubuntu runner version to 24.04
imunproductive Dec 4, 2024
64b91ad
install protoc 29.1
imunproductive Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@
name: CI

on:
pull_request:
pull_request_target:
types: [opened, synchronize, reopened]

permissions:
contents: read

jobs:
check-formatting:
name: Check formatting
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -31,7 +34,7 @@ jobs:
include:
- name: Linux
target: x86_64-unknown-linux-gnu
os: ubuntu-latest
os: ubuntu-24.04
# - name: macOS
# target: x86_64-apple-darwin
# os: macos-latest
Expand All @@ -55,6 +58,11 @@ jobs:
toolchain: 1.81.0
components: rustfmt
targets: ${{ matrix.target }}
- name: Install protoc
uses: arduino/setup-protoc@v3
with:
version: "29.1"
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Build library
id: check-lib
if: ${{ always() }}
Expand All @@ -78,12 +86,13 @@ jobs:
cargo +${{ steps.install-rust.outputs.name }} test --target ${{ matrix.target }} --workspace --test "*" --no-fail-fast
review-pr:
name: Review PR
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: ${{ always() }}
needs:
- check-formatting
- check-targets
permissions:
contents: read
pull-requests: write
steps:
- uses: actions/github-script@v7
Expand Down