Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flutter_math_fork lib #111

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

xdidx
Copy link

@xdidx xdidx commented May 23, 2023

There are errors when I'm building the example due to flutter_math_fork.
Upgrade to 0.7.0 fix the issues

@xdidx xdidx changed the title Upgrade flutter_math_fork Upgrade flutter_math_fork lib May 23, 2023
@xdidx xdidx marked this pull request as ready for review May 23, 2023 19:38
@asjqkkkk
Copy link
Owner

Hi @xdidx , could you please verify if you have tested that the updated version of flutter_math_fork is compatible with other libs specified in the pubspec.yaml file?

@xdidx
Copy link
Author

xdidx commented May 24, 2023

Yes it's works.
I added the pubspec.lock only for the example app (based on https://dart.dev/guides/libraries/private-files).

@asjqkkkk
Copy link
Owner

Hi @xdidx , flutter_math_fork: ^0.7.0 is not working for flutter 3.3.1, I believe that if we want to merge this pull request, there are still many dependencies related to the flutter version that need to be addressed in the project.

Because example depends on flutter_math_fork >=0.7.0 which requires SDK version >=3.0.0 <4.0.0, version solving failed.
pub get failed (1; Because example depends on flutter_math_fork >=0.7.0 which requires SDK version >=3.0.0 <4.0.0, version solving failed.)

@xdidx
Copy link
Author

xdidx commented Jun 1, 2023

On the Flutter stable branch, flutter version 3.10.0 released on 10/05/2023 uses the Dart SDK v3.0.0
I've already done the flutter upgrade command to get it so I didn't get any error.

Does this command solve the problem ?

@asjqkkkk
Copy link
Owner

asjqkkkk commented Jun 5, 2023

On the Flutter stable branch, flutter version 3.10.0 released on 10/05/2023 uses the Dart SDK v3.0.0 I've already done the flutter upgrade command to get it so I didn't get any error.

Does this command solve the problem ?

Hi @xdidx , sorry for responding late, my meaning is that this pull request only performs partial upgrades, and corresponding modifications need to be made to the pubspec.yaml file in the project root directory, as well as to the workflows in the GitHub action. Otherwise, issues will arise in those areas that were not modified, and I will need to modify them again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants