Skip to content

Conversation

@asmeraz
Copy link
Owner

@asmeraz asmeraz commented May 13, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Uploading assignent-2

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few review changes:

  1. Replace the hardcoded absolute paths to relative paths so that a Learning support can run the code successfully as well. For example: change "c:/users/Adriana/python/05_src/data/assignment_2_data/inflammation_01.csv" to "../../05_src/data/assignment_2_data/inflammation_01.csv"

  2. In Question 1, the requirement is to use readlines/readline method to read the csv file into a variable and use the variable in a for loop to print each row. print(f.readline()) will not read the file in a variable. Please make the appropriate changes.

  3. Changes to assignment_1.ipynb should not be included in this pull request.
    Please refer to following thread of slack https://uoft-dsi-certificates.slack.com/archives/C08JWD6RRU3/p1747084222526419 to fix this.

  4. This a minor point: there's no space before and after the = in hascero=check_zeros(patient_summary). It's best to follow a consistent style throughout the code. PEP 8 (https://peps.python.org/pep-0008/) is a great reference for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants