Skip to content

Conversation

@asmeraz
Copy link
Owner

@asmeraz asmeraz commented Apr 14, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link
Owner Author

@asmeraz asmeraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link
Owner Author

@asmeraz asmeraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status comment
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2 coworker-changes branch not found in commit history

Please address the issues listed above.

@dtxe
Copy link

dtxe commented Apr 14, 2025

The main issue is that the autograder isn't able to see your coworker-changes merge, because it is also present in your main branch.

Please revert your main branch to match the upstream by running:

git remote add upstream https://github.com/UofT-DSI/shell   # add the UofT-DSI remote as upstream
git fetch upstream                                          # download into git database
git switch -C main upstream/main                            # overwrite your local main branch with upstream
git push --force -u origin main                             # overwrite your GitHub main branch with upstream

Then close and re-open your pull request.

An example of this fix is here: https://github.com/simeon-demo/asmeraz_shell/actions/runs/14451995519

Additionally, it appears there are changes to the GitHub Actions workflows in your repository. This may lead to unexpected behaviour.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autograder results

question status
Part 1 - Q1
Part 1 - Q2
Part 1 - Q3
Part 1 - Q4
Part 1 - Q5
Part 1 - Q6
Part 1 - Q7
Part 1 - Q8
Part 2

@asmeraz
Copy link
Owner Author

asmeraz commented Apr 14, 2025

It worked. Thanks for you support

@l-mack
Copy link

l-mack commented Apr 15, 2025

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants