[CALCITE-2980] Implement the FORMAT clause of the CAST operator

asolimando · Apr 11, 2024 · cc1d46a · cc1d46a
1 parent e7c1f0c
commit cc1d46a
Show file tree

Hide file tree

Showing 16 changed files with 838 additions and 416 deletions.
diff --git a/core/src/main/codegen/templates/Parser.jj b/core/src/main/codegen/templates/Parser.jj
@@ -6216,6 +6216,7 @@ SqlNode BuiltinFunctionCall() :
     final SqlNode node;
     final SqlLiteral style; // mssql convert 'style' operand
     final SqlFunction f;
+    final SqlNode format;
 }
 {
     //~ FUNCTIONS WITH SPECIAL SYNTAX ---------------------------------------
@@ -6232,6 +6233,7 @@ SqlNode BuiltinFunctionCall() :
         |
             <INTERVAL> e = IntervalQualifier() { args.add(e); }
         )
+        [ <FORMAT> format = StringLiteral() { args.add(format); } ]
         <RPAREN> {
             return f.createCall(s.end(this), args);
         }

diff --git a/core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java b/core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
@@ -2792,7 +2792,7 @@ private static class FormatDatetimeImplementor
         method = BuiltInMethod.FORMAT_TIMESTAMP.method;
       }
       return implementSafe(method,
-          ImmutableList.of(translator.getRoot(), operand0, operand1));
+          ImmutableList.of(operand0, operand1));
     }
   }
 
@@ -3283,11 +3283,23 @@ private static class CastImplementor extends AbstractRexCallImplementor {
 
     @Override Expression implementSafe(final RexToLixTranslator translator,
         final RexCall call, final List<Expression> argValueList) {
-      assert call.getOperands().size() == 1;
+      assert call.operandCount() <= 2;
       final RelDataType sourceType = call.getOperands().get(0).getType();
 
-      // Short-circuit if no cast is required
       RexNode arg = call.getOperands().get(0);
+      ConstantExpression formatExpr;
+
+      // Check for FORMAT clause if second operand is available in RexCall.
+      if (call.operandCount() == 2) {
+        RexLiteral format = (RexLiteral) translator.deref(call.getOperands().get(1));
+        formatExpr =
+            (ConstantExpression) RexToLixTranslator.translateLiteral(format, format.getType(),
+                translator.typeFactory, NullAs.NULL);
+      } else {
+        formatExpr = NULL_EXPR;
+      }
+
+      // Short-circuit if no cast is required
       if (call.getType().equals(sourceType)) {
         // No cast required, omit cast
         return argValueList.get(0);
@@ -3303,7 +3315,7 @@ private static class CastImplementor extends AbstractRexCallImplementor {
           nullifyType(translator.typeFactory, call.getType(), false);
       boolean safe = call.getKind() == SqlKind.SAFE_CAST;
       return translator.translateCast(sourceType,
-              targetType, argValueList.get(0), safe);
+          targetType, argValueList.get(0), safe, formatExpr);
     }
 
     private static RelDataType nullifyType(JavaTypeFactory typeFactory,