Skip to content

fix: use distinct names for the initial build+cycle otel events for run--watch #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jbedard wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: use distinct names for the initial build+cycle otel events for run--watch #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/aspect/run/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ func (runner *Run) runWatch(ctx context.Context, bazelCmd []string, bzlCommandSt

logger.Infof("initial --watch build: %v", initCmd.Args)

if err := runner.runCmd(initCtx, initCmd, "Run.Subscribe.Build"); err != nil {
if err := runner.runCmd(initCtx, initCmd, "Run.Init.Build"); err != nil {
return nil, nil, fmt.Errorf("initial bazel command failed: %w", err)
}

Expand Down Expand Up @@ -392,7 +392,7 @@ func (runner *Run) runWatch(ctx context.Context, bazelCmd []string, bzlCommandSt
}

// Init() with the full runfiles list
cctx, initCycleTrace := runner.tracer.Start(initCtx, "Run.Cycle")
cctx, initCycleTrace := runner.tracer.Start(initCtx, "Run.Init.Cycle")
defer func() {
if retErr != nil {
initCycleTrace.SetStatus(codes.Error, retErr.Error())
Expand Down
Loading