refactor: upgrade aspect-gazelle, support incremental-build-protocol v3#334
refactor: upgrade aspect-gazelle, support incremental-build-protocol v3#334
Conversation
30cf416 to
d6918d3
Compare
|
d6918d3 to
6648609
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6648609116
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ctctx, cycleTrace := runner.tracer.Start(tctx, "Run.Cycle") | ||
| defer cycleTrace.End() | ||
|
|
||
| if err := incrementalProtocol.CycleReset(ctctx); err != nil { |
There was a problem hiding this comment.
Preserve fallback for pre-v2 watch clients
When the target connects with an older IBP client that negotiates v1 but watches sources, a watchman fresh-instance now sets cycleIsReset and reaches CycleReset; the upgraded server rejects that call for negotiated versions below v2 (CYCLE_RESET requires protocol >= v2), so the watch loop returns an error instead of notifying the target as it did before with a CYCLE/nil-sources message. This only shows up for source-watching targets built against the older protocol after a fresh-instance/recrawl, but it breaks backwards-compatible watch sessions.
Useful? React with 👍 / 👎.


Changes are visible to end-users: no
Test plan