Skip to content

refactor: upgrade aspect-gazelle, support incremental-build-protocol v3#334

Merged
jbedard merged 1 commit intomainfrom
chore/upgrade-aspect-gazelle-75d3c1f7
May 9, 2026
Merged

refactor: upgrade aspect-gazelle, support incremental-build-protocol v3#334
jbedard merged 1 commit intomainfrom
chore/upgrade-aspect-gazelle-75d3c1f7

Conversation

@jbedard
Copy link
Copy Markdown
Member

@jbedard jbedard commented May 9, 2026

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • Manual testing; please provide instructions so we can reproduce:

@jbedard jbedard force-pushed the chore/upgrade-aspect-gazelle-75d3c1f7 branch from 30cf416 to d6918d3 Compare May 9, 2026 00:57
@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented May 9, 2026

Test

11 test targets passed

Targets
//integration_tests/aspect:configure_test [k8-fastbuild] 1m 55s
//integration_tests/aspect:flags_test [k8-fastbuild]     2m 7s
//integration_tests/aspect:help_test [k8-fastbuild]      1m 44s
//integration_tests/aspect:hints_test [k8-fastbuild]     1m 46s
//integration_tests/aspect:info_test [k8-fastbuild]      1m 24s
//integration_tests/aspect:init_test [k8-fastbuild]      214ms
//integration_tests/aspect:lint_test [k8-fastbuild]      1m 9s
//integration_tests/aspect:reenter_test [k8-fastbuild]   22s
//integration_tests/aspect:run_test [k8-fastbuild]       1m 20s
//integration_tests/aspect:telemetry_test [k8-fastbuild] 44s
//integration_tests/aspect:version_test [k8-fastbuild]   1m 31s

Total test execution time was 14m 6s. 80 tests (87.9%) were fully cached saving 9s.


Buildifier

@jbedard jbedard force-pushed the chore/upgrade-aspect-gazelle-75d3c1f7 branch from d6918d3 to 6648609 Compare May 9, 2026 00:59
@jbedard jbedard marked this pull request as ready for review May 9, 2026 05:38
@jbedard jbedard merged commit 98cdee8 into main May 9, 2026
3 checks passed
@jbedard jbedard deleted the chore/upgrade-aspect-gazelle-75d3c1f7 branch May 9, 2026 05:38
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6648609116

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pkg/aspect/run/run.go
ctctx, cycleTrace := runner.tracer.Start(tctx, "Run.Cycle")
defer cycleTrace.End()

if err := incrementalProtocol.CycleReset(ctctx); err != nil {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve fallback for pre-v2 watch clients

When the target connects with an older IBP client that negotiates v1 but watches sources, a watchman fresh-instance now sets cycleIsReset and reaches CycleReset; the upgraded server rejects that call for negotiated versions below v2 (CYCLE_RESET requires protocol >= v2), so the watch loop returns an error instead of notifying the target as it did before with a CYCLE/nil-sources message. This only shows up for source-watching targets built against the older protocol after a fresh-instance/recrawl, but it breaks backwards-compatible watch sessions.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant