Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #90 added limitation on zipcode input #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThreeDP
Copy link

@ThreeDP ThreeDP commented Jul 26, 2024

In order to not change the scope of the project, I added a small change of maximum size to the frontend zipcode input.

I added this item because it doesn't change the project too much, but it helps people who are starting the project and may be confused about whether the order api is working or not.

It was a feeling I had when sending a zipcode that generates the exception, because in my country zipcodes are 8 characters long.

@ThreeDP
Copy link
Author

ThreeDP commented Jul 26, 2024

If given permission I can create a validation for this within Orders.Api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant