Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pjsip: Add tests for Advanced Codec Negotiation (ACN) #20

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

pjsip: Add tests for Advanced Codec Negotiation (ACN) #20

wants to merge 1 commit into from

Conversation

maximilianfridrich
Copy link
Contributor

No description provided.

@asterisk-org-access-app asterisk-org-access-app bot requested a review from a team August 30, 2023 09:27
@asterisk-org-access-app
Copy link

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment stating "No cherry-picks required" so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add "No cherry-picks required".

@maximilianfridrich
Copy link
Contributor Author

maximilianfridrich commented Aug 30, 2023 •
edited
Loading

Update: No cherry-picks needed.

@maximilianfridrich maximilianfridrich mentioned this pull request Aug 30, 2023
Draft
@maximilianfridrich
Copy link
Contributor Author

This PR must use the corresponding asterisk PR which implements the codec negotiation:

In this PR, 10 existing tests were adopted to reflect the new behavior. For those tests, pjsip.conf had to be adopted to use the new ACN settings. The default settings prefer the pending stream while these tests expect the configured settings to be preferred.

@jcolp jcolp marked this pull request as draft August 30, 2023 10:34
@maximilianfridrich maximilianfridrich mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-submit-testing-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maximilianfridrich