Skip to content

Add an UnusableDependencies incompatibility kind#4

Merged
zanieb merged 1 commit intomainfrom
zanie/unusable-deps
Nov 16, 2023
Merged

Add an UnusableDependencies incompatibility kind#4
zanieb merged 1 commit intomainfrom
zanie/unusable-deps

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Nov 16, 2023

As in pubgrub-rs#153 but with the reason string that I need.

See discussion in the upstream for future plans that will replace this work. In the meantime, I'll make use of this.

Includes Range.is_empty() -> bool which I need to detect empty version sets.

@Eh2406
Copy link

Eh2406 commented Nov 16, 2023

What feedback are you looking for, and how can I best provide it?

@zanieb
Copy link
Member Author

zanieb commented Nov 16, 2023

Oh no feedback required here! I intend to make the changes here redundant with the changes discussed over in pubgrub-rs#153 but wanted to work off this commit until then. If anything, #1 might be of interest to you.

zanieb added a commit that referenced this pull request Nov 28, 2023
zanieb added a commit that referenced this pull request Nov 29, 2023
zanieb added a commit that referenced this pull request Dec 1, 2023
zanieb added a commit that referenced this pull request Dec 1, 2023
zanieb added a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants