-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM64 builds for Windows #387
base: main
Are you sure you want to change the base?
Conversation
116a612
to
bb7bc6e
Compare
We're failing missing
on amd64, you can see we copy this file
but we don't on arm64
Looks like |
9ada4a7
to
49b6f84
Compare
Co-authored-by: Adrian Antkowiak <[email protected]>
By manually copying the
Where we fail to run the PGO tests because, of course, we're not on an ARM runner. |
I don't really know what the plan is here. There aren't public ARM Windows runners (though they might be eventually actions/runner-images#10820 / github/roadmap#970). We (Astral) could pay for runners, but I can't set that up in this repository. We could skip PGO, but we're still going to fail later (we need to invoke |
Now that this is in the Astral org, I intend to try adding an ARM runner. |
As a note, before releasing this we need to add proper prioritization for these builds to uv — as arm64 wheels are not prevalent we may not want to actually use these builds by default. |
FWIW, we still consider them experimental in upstream, and I'm regularly tracking whether to make them non-experimental. Right now, that's not going to happen anytime soon, unless I get sick of the people who are meant to be using them going "I'm not going to fix my package/tool until it's non-experimental" when it's still experimental because they haven't fixed anything (okay, clearly I'm already sick of them, but I can't shout at them all at once 😆 ) When we think it's time to unleash users on these builds by default, it'll be announced as part of an upstream beta release (or earlier, but probably not earlier - definitely no later than beta). |
Picking up #93