Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom download URL #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mamercad
Copy link

This would help folks with GHES, etc

@mamercad mamercad requested a review from eifinger as a code owner February 24, 2025 17:01
@mamercad mamercad force-pushed the mamercad/add-custom-download-url branch from 5d9c90f to 56cf771 Compare February 24, 2025 17:09
@eifinger
Copy link
Collaborator

Hi and thank you for your PR.

Can you please give a bit more information?

  • How exactly does this help GHES users?
  • What doesn't work currently?
  • What is etc?

Thank you

@mamercad
Copy link
Author

Hi and thank you for your PR.

Can you please give a bit more information?

  • How exactly does this help GHES users?
  • What doesn't work currently?
  • What is etc?

Thank you

We run GHES and we would do something like this:

custom-download-url: "https://github.internal.tld/${OWNER}/${REPO}/releases/download/${version}/${artifact}${extension}"

I don't know TypeScript, so, guessing through things in this PR.

@eifinger
Copy link
Collaborator

I still don't understand why this change is needed. If you want to download from your own source, why do you need this action instead of "curl-ing" your private url and add the matchers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants